fix(doctor): --format only accepted text/json, rejected compact/markdown/ai/sarif/graphml - #215
Merged
Merged
Conversation
…own/ai/sarif/graphml Every other umbrella command accepts the global 6-way --format choice list (json/markdown/ai/sarif/compact/graphml). doctor.py redefined --format locally with choices=['text','json'] only, so 'codelens doctor . --format compact' errored with 'invalid choice: compact' — inconsistent with the documented convention (--format compact is the recommended token-efficient default for AI agent consumption per README/CONTEXT.md). Found via real-codebase validation while auditing doctor against KDS backend. Fix: widen local choices to the full global list; update the fmt fallback/dispatch logic so any non-'text' format (not just 'json') is handed to the shared top-level formatter, same as every other umbrella command.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while auditing
doctorcommand against KDS backend —codelens doctor . --format compacterrored withinvalid choice: 'compact'.Every other umbrella command accepts the global 6-way
--formatchoice list.doctor.pyredefined--formatlocally withchoices=['text','json']only — inconsistent with the documented convention that--format compactis the recommended token-efficient default.Fix: widen local choices to the full global list; update dispatch logic so any non-'text' format is handed to the shared top-level formatter, same as every other command. Verified
--format compactnow works and returns proper compact JSON.Test suite: 12 pre-existing failures in
test_doctor.py(schema drift, already documented in CONTEXT.md) confirmed unrelated — same failures present on main before this change.